WIP: diagrams/dts_issues.py: improvements before zdm2 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
It gives me reasonable results for DTS repos with no manual offset modifications. To be tested against other repos as well. Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
macpijan
changed the title
Contributor
|
@macpijan, what is the readiness of this PR? Shall we review it? |
Contributor
|
@macpijan ? It will rot if it stays here longer. |
Contributor
Author
|
I am not sure if it is applicable and I think it breaks other diagrams (example: https://github.com/Dasharo/presentations/blob/f31136a095e4ffe519ebf0f498014a9c4af470a2/img/dug_10/dasharo_prs_osfv_cli_diff.png). This was my failed approach to automate adding offsets to the diagrams so the look "good". As currently it was done manually on per-diagram basis. Maybe I (or someone else) comes back here with next DTS update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.